Imported repos list empty state updates #19096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
approved these changes
Nov 20, 2023
components/dashboard/src/repositories/list/RepoListEmptyState.tsx
Outdated
Show resolved
Hide resolved
| <div className={cn("w-full flex justify-center mt-2 rounded-xl bg-gray-100 dark:bg-gray-800 px-4 py-20")}> | ||
| <div className="flex flex-col justify-center items-center text-center space-y-4"> | ||
| <Heading2>No repositories yet</Heading2> | ||
| <Subheading className="max-w-md"> |
There was a problem hiding this comment.
Could we change the color in dark mode for more contrast?
There was a problem hiding this comment.
It applies to this as well 🙏
There was a problem hiding this comment.
Good catch. I think I'm going to look at swapping all our headings to the podkit ones to at least get that stuff cleaned up and using the updated components.
| Load more | ||
| </LoadingButton> | ||
| ) : ( | ||
| hasMoreThanOnePage && <TextMuted>All repositories are loaded</TextMuted> |
There was a problem hiding this comment.
We could get really cheesy here one day 😄
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes some updates to the empty states of the Imported Repos list.
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at b1260de
Refactored the repository list page and its components to improve the search and filter functionality, the code structure, and the user interface. Extracted the
RepositoryTableandRepoListEmptyStatecomponents to separate files and simplified theuseListConfigurationshook.Related Issue(s)
Fixes EXP-932
How to test
asdf- you should see the no matching results messageDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold