Skip to content

[ws-manager-mk2] Add node utilization metrics #19105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Nov 21, 2023

Description

Adds node utilization metrics, reporting per node how much cpu/memory is requested by workspaces (using the resource request values of their workspace class).

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at 04b9fbb

Added a new metric to measure workspace resource requests per node. This metric, workspaceNodeUtilization, is collected and exposed by the ws-manager-mk2 controller using a custom type nodeUtilizationVec. This can help monitor and optimize the node allocation and utilization of workspaces.

Related Issue(s)

Part of ENG-1071

How to test

Tested in a preview env

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a walkthrough by @WVerlaek. LGTM

@roboquat roboquat merged commit f9e6a63 into main Nov 23, 2023
@roboquat roboquat deleted the wv/node-capacity-metrics branch November 23, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants