[configcat] ensure that browser updates the cache #19125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iQQBot
approved these changes
Nov 23, 2023
|
Verified that it actually gets 304 from server now, not from browser cache: |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it is a req to guruantee that ETag works: https://stackoverflow.com/a/68407563
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at d2efa84
Set
Cache-Controlheader tono-cachefor proxy responses with feature flags. This prevents the browser from using stale feature flags that may not match the TTL set by the ConfigCat service.Related Issue(s)
fix EXP-979
How to test
Deploy to dogfood, toggle FF, check that it is updated on Dashboard.
Documentation
Preview status
https://ak-proxy-c63f583f0d1.preview.gitpod-dev.com/workspaces
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold