Repo List - Style updates #19157
Merged
Repo List - Style updates #19157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfcontained
force-pushed
the
brad/repo-list-style-updates
branch
from
badcc90 to
c27d5f9
Compare
filiptronicek
approved these changes
Nov 30, 2023
| @@ -27,7 +27,7 @@ export const TableHeader = React.forwardRef<HTMLTableSectionElement, React.HTMLA | |||
| return ( | |||
| <thead | |||
| ref={ref} | |||
| className="[&_th]:p-3 [&_th]:bg-gray-100 dark:[&_th]:bg-gray-800 [&_th:first-child]:rounded-tl-md [&_th:last-child]:rounded-tr-md text-semibold" | |||
| className="[&_th]:py-2 [&_th]:px-4 [&_th]:bg-gray-100 [&_th]:font-semibold dark:[&_th]:bg-gray-800 [&_th:first-child]:rounded-tl-md [&_th:last-child]:rounded-tr-md" | |||
There was a problem hiding this comment.
Could you please explain what this [&_th] syntax does?
On the Tailwind playground, [&_th]:py-2 translates to the following, but it did not help too much 😄.
.\[\&_th\]\:py-2 th{
padding-top: 0.5rem;
padding-bottom: 0.5rem
}There was a problem hiding this comment.
It applies the padding to any descendant <th> of the <thead> component.
| @@ -46,12 +45,10 @@ export const RepositoryListItem: FC<Props> = ({ configuration }) => { | |||
| {prebuildsEnabled ? ( | |||
| <CheckCircle2Icon size={20} className="text-green-500" /> | |||
| ) : ( | |||
| <AlertTriangleIcon size={20} className="text-red-500" /> | |||
| <AlertTriangleIcon size={20} className="text-kumquat-base" /> | |||
There was a problem hiding this comment.
Love that we're making this less scary, no prebuild shaming!
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a couple small styling issues on the repo list page.
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at 70eb648
Updated the styling and font weights of some dashboard components to improve consistency and readability. Changed the alert icon color in
RepoListItem.tsx, and appliedfont-semiboldto the button and header text inSortableTable.tsxandTable.tsx.How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold