-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adding Switch podkit component to prebuild settings page #19171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gray: podkitColors.gray, | ||
// Podkit colors - eventually we'll only use these colors | ||
// Once migrated, we can remove the colors above and shift this up under theme directly instead of extend | ||
"pk-content": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First step in setting up the new colors for the design system. This will let us reference contextual class names in our podkit components.
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super stoked about the color abstractions. Is there a way that they would be theme / state aware, so that pk-surface-primary
+ pk-surface-primary-dark
could become just pk-surface-primary
?
Either way, happy to leave for a follow-up.
Prebuilds reduce wait time for new workspaces. Enabling requires permissions to configure repository | ||
webhooks.{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is safe to remove since it's a part of the switch now. Same goes for the link below, but GitHub did not let me expand my suggestion that far
Prebuilds reduce wait time for new workspaces. Enabling requires permissions to configure repository | |
webhooks.{" "} | |
Prebuilds reduce wait time for new workspaces. |
components/dashboard/src/repositories/detail/ConfigurationDetailPrebuilds.tsx
Outdated
Show resolved
Hide resolved
…ilPrebuilds.tsx Co-authored-by: Filip Troníček <[email protected]>
I think there is probably a way, I’ll try and find some time to look into it, would be nice to figure out before proliferating these classnames too much. |
/unhold |
Description
This primarily just adds a new
<Switch/>
component to podkit. I also dropped it onto the Prebuilds settings for repo configs. It's not wired up to any api calls yet, wanted to keep this PR scoped to just the component and dropping it into a surface to see it.Summary generated by Copilot
🤖[deprecated] Generated by Copilot at 7b5a424
This pull request adds a switch component to the dashboard UI using the
@podkit
design system and a new dependency on@radix-ui/react-switch
. It also allows users to enable or disable prebuilds for a repository in the configuration detail view.How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold