Frontend development: redirect instead of proxy #19177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/frontend-dev-direct
branch
from
9317b88 to
9a8ba4d
Compare
This removes the "proxy needs network access to upstream" constraint, by relying on the developers browser
geropl
force-pushed
the
gpl/frontend-dev-direct
branch
from
9a8ba4d to
c74bcb3
Compare
geropl
changed the title
We could make it open with another port and mark this port as public in |
And make developer role granting as a leeway script |
|
@mustard-mh @selfcontained Now also with the relevant commit... 😑 |
mustard-mh
approved these changes
Dec 5, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows you to overlay the Dashboard with any other version, as long as you can reach the source from your browser.
Steps
Just like before, do:
Get a workspace with your modified version of dashboard
yarn start-localOn the Gitpod installation you want to change the dashboard on
In this preview:
leeway run components:make-user-admin(or as me to do it for you)a. go to /admin/users and grant yourself the "developer" role
gp url 3000, and use that value to stick it into the "header editor" of your choice, so it matches this previewYou should now be able to change the dashboard on the fly, incl. hot-reload. 🎉
Thank you @selfcontained for the idea and help with webpack!
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at 9317b88
Refactored the proxy plugin for frontend development with hot reloading and live reloading. Renamed the package and module from
workspacedownloadtofrontend_devand added unit tests for the index.html rewriting logic. Modified the filesfrontend_dev.go,frontend_dev_test.go, andgo.mod.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold