New Prebuild Settings UI for repo configs #19184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfcontained
force-pushed
the
brad/new-prebuild-settings
branch
from
165130a to
a9c3197
Compare
filiptronicek
approved these changes
Dec 3, 2023
| <ConfigurationSettingsField> | ||
| <form onSubmit={handleSubmit}> | ||
| <Heading3>Prebuild Settings</Heading3> | ||
| <Subheading className="max-w-lg">These settings will be applied on every Prebuild.</Subheading> |
There was a problem hiding this comment.
These settings will be applied on every Prebuild.
This is more of an aside since it's relevant to all of the work we've been doing with Configs so far: do we or do we not capitalize feature names? I like the aesthetics of doing so, but am not convinced too hard. Either way, it would be great to settle this so that we can make it consistent.
cc @loujaybee since you may have an opinion :)
components/dashboard/src/repositories/detail/prebuilds/PrebuildSettingsForm.tsx
Outdated
Show resolved
Hide resolved
components/dashboard/src/repositories/detail/prebuilds/PrebuildSettingsForm.tsx
Show resolved
Hide resolved
components/dashboard/src/repositories/detail/workspaces/WorkpaceSizeOptions.tsx
Show resolved
Hide resolved
components/dashboard/src/repositories/detail/prebuilds/PrebuildSettingsForm.tsx
Show resolved
Hide resolved
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the prebuild settings UI in the repo config area and sets up the api to it.
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at dccbe44
This pull request adds and improves features for editing the prebuild settings of a repository configuration in the dashboard. It introduces new components for the prebuild settings form, the workspace class options, and the select input field, and refactors some existing components for better code reuse and UI feedback. It also updates the
updateConfigurationmutation to handle the prebuild settings.Issue
Fixes EXP-874
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold