[db] fix the query for non-fga migrated users #19194
Conversation
|
/unhold |
| .createQueryBuilder("user") | ||
| .select(["id"]) |
There was a problem hiding this comment.
IMO we should be able to keep the select to reduce the amount of bytes shuffled around.
There was a problem hiding this comment.
@svenefftinge I tried, and it's indeed this line that fails the method, .select(["user.id"]) works. 🙄 So this is different to other querybuilder methods, which does not auto-namespace it's argument. And also, MySQL happily executes and retunrs and empty result... 🙈
| .createQueryBuilder("user") | ||
| .select(["id"]) | ||
| .where({ | ||
| fgaRelationshipsVersion: Not(Equal(fgaRelationshipsVersion)), |
There was a problem hiding this comment.
@svenefftinge Can you share some insight into what's not working here, e.g. how the resulting query looks like?
There was a problem hiding this comment.
no, I wrote a test and verified it failed and then used the pattern we use in other queries as well to make the test pass.
Description
Fixes the query for listing users that should be migrated by the FGA job.
At the moment the query is wrong and returns empty lists. As a consequence many users that haven't been active recently are not considered by FGA and can therefore not be found using our admin dashboard.
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at d43464b
Improve FGA migration query and add test case. The changes exclude built-in users from the query that selects users who need to migrate to a newer fine-grained access (FGA) version. The changes also add a unit test to verify the query logic and results.
Related Issue(s)
Fixes #EXP-1021
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold