[authorizer] prepare Authorizer for SubjectId rollout #19195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
reviewed
Dec 6, 2023
| @@ -165,7 +166,8 @@ export type RequestContextSeed = Omit<RequestContext, "requestId" | "startTime" | |||
| }; | |||
|
|
|||
| /** | |||
| * The context all our request-handling code should run in. | |||
| * Creates a _root_ context request-handling code should run in. MANDATORY for any authorization to work. | |||
There was a problem hiding this comment.
if we never want to nest these, we should add a check and throw an error in case we do
There was a problem hiding this comment.
That's an excellent point. I will add an error log for now, and make a note to bump it to an error next week (after checking it does not break somewhere) to not defer progress here. 📓
svenefftinge
reviewed
Dec 6, 2023
svenefftinge
reviewed
Dec 6, 2023
| it("all tests", async () => { | ||
| interface Test { | ||
| name: string; | ||
| passed: Subject; |
There was a problem hiding this comment.
nit: passedSubjectId would have helped me understanding the purpose of this
svenefftinge
reviewed
Dec 6, 2023
svenefftinge
reviewed
Dec 6, 2023
svenefftinge
approved these changes
Dec 6, 2023
geropl
force-pushed
the
gpl/authorizer-rollout
branch
from
1f93161 to
133cab5
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepares the central function in
Authorizerto switch the way we determineSubjectId, and adds exhaustive tests for it.Summary generated by Copilot
🤖[deprecated] Generated by Copilot at 1f93161
Refactored and tested the authorization logic for handling different subjects in the request context. Moved some types and functions to separate files for better organization and readability. Added error handling and metrics for missing subject id when a feature flag is on. Improved the documentation and comments for the request context interface and related utilities.
Related Issue(s)
Related: EXP-1022
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold