Skip to content

[experimental] add ssh certificate authorities as feature flags #19208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Dec 7, 2023

Description

[experimental] add ssh certificate authorities as feature flags

This provides us with a solution that allows for quick rollback. When this feature is stable, we can remove the experimental flag.

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at ae4edb1

This pull request adds a new feature flag for enabling SSH certificate authorities (SSH CA) for workspaces. It updates the server, ws-manager, ws-manager-mk2, and gitpod-protocol components to support and use the new flag. It also modifies the core protocol buffer definitions and the generated files to include the new flag.

Related Issue(s)

Fixes ENG-1331

How to test

  1. start a workspace in preview env, the the feature flags for preview env is enabled by default
  2. connect workspace via ssh, run ls -lah ~/.ssh/ is should not have authorized_keys
  3. go to configcat, set disable isSSHCertificateAuthoritiesEnabled for your userId
  4. wait for 5min
  5. start a new workspace, redo the test above, when run ls -lah ~/.ssh/ you should see authorized_keys

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@iQQBot
Copy link
Contributor Author

iQQBot commented Dec 7, 2023

With feature flags enabled With feature flags disabled
image image

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to unblock

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but, leaving the hold.

Preview is down, so cannot test. Rebuilding now, and will retest in a couple hours. After which, if okay, I will remove the hold.

@roboquat roboquat merged commit 6ecc991 into main Dec 7, 2023
@roboquat roboquat deleted the pd/ssh-ca-ff branch December 7, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants