Scope config lookup to org #19216
Closed
Scope config lookup to org #19216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
force-pushed
the
ft/org-scoped-config-lookup
branch
2 times, most recently
from
d3ee726 to
4590baa
Compare
filiptronicek
force-pushed
the
ft/org-scoped-config-lookup
branch
from
4590baa to
508715d
Compare
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 7133375257
|
|
Superseeded by #19217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a workspace, we check if by any chance there aren't multiple configurations for this repository, because we cannot just guess it by the context URL you provided. This lookup was previously done on a global level, so if anyone in the world configured a repo which you also had configured, you would start getting a
Multiple projects found for clone URL.error.This change tweaks the behavior so that even if you had a repo configured across two organizations, only the one for the currently active one will apply.
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at 203f6a8
Added an
organizationIdoption to thefindProjectsByCloneUrlmethod in various classes to support filtering projects by clone URL and organization. This improves the accuracy and reliability of workspace context creation.Related Issue(s)
Fixes EXP-962
How to test
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled.