Skip to content

Reflect Privacy policy update #19230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Reflect Privacy policy update #19230

merged 1 commit into from
Dec 11, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Dec 11, 2023

Description

Update the privacy policy's effective date so that users get prompted to acknowledge it again.

See https://github.com/gitpod-io/website/pull/4052 for more about the update itself.

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at 7154a9d

Update privacy policy notification date. This change updates the PRIVACY_POLICY_LAST_UPDATED constant in AppNotifications.tsx to show a banner to users who have not seen the latest privacy policy.

How to test

  1. This is fine to test in production, we should rather add automated tests for it.

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@@ -15,7 +15,7 @@ import { User as UserProtocol } from "@gitpod/gitpod-protocol";
import { User } from "@gitpod/public-api/lib/gitpod/v1/user_pb";

const KEY_APP_DISMISSED_NOTIFICATIONS = "gitpod-app-notifications-dismissed";
const PRIVACY_POLICY_LAST_UPDATED = "2023-10-17";
const PRIVACY_POLICY_LAST_UPDATED = "2023-12-11";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth to add an endpoint to website to get last updated date automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustard-mh we totally could. I'm not sure if it's worth the effort now but it would be nice to automate in the future 👍

@filiptronicek filiptronicek self-assigned this Dec 11, 2023
@roboquat roboquat merged commit 99ad568 into main Dec 11, 2023
@roboquat roboquat deleted the ft/pp-update branch December 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants