Skip to content

Migrate workspaceService updatePort method #19234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Migrate workspaceService updatePort method #19234

merged 3 commits into from
Dec 11, 2023

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Dec 11, 2023

Description

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at fd52883

Add a new API endpoint for updating the port of a workspace. Implement the client and server logic for the new endpoint in Go, TypeScript, and JSON-RPC. Define the RPC method and messages in the workspace.proto file. Improve the error handling and flexibility of the openPort method in the workspace-service. Remove an unused import in the gitpod-server-impl.ts file.

Related Issue(s)

Fixes #

How to test

No need to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh mustard-mh marked this pull request as ready for review December 11, 2023 11:23
@mustard-mh mustard-mh requested a review from a team as a code owner December 11, 2023 11:23
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@roboquat roboquat merged commit 0b1e5d4 into main Dec 11, 2023
@roboquat roboquat deleted the hw/papi-port branch December 11, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants