Skip to content

[auth] RequestContext: add missing runWithSubjectId #19235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Dec 11, 2023

Description

Adds missing calls to runWithSubjectId for: heartbeating and codeSync

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at e8c70e2

This pull request improves the request context handling for code sync and user activity operations. It uses a helper function to associate the user's subject ID with the requests and propagate it to downstream services and logging. This affects the files code-sync-service.ts and user-controller.ts.

Related Issue(s)

Related: EXP-918

How to test

  • start a workspace
  • check server logs, and see that there are no lines containing "SubjectId mismatch"

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member Author

geropl commented Dec 11, 2023

Waiting for preview to test myself 👀

@geropl
Copy link
Member Author

geropl commented Dec 11, 2023

My tests look good:

  • heartbeating works
  • code-sync works

image

✔️

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@geropl
Copy link
Member Author

geropl commented Dec 11, 2023

/unhold

@roboquat roboquat merged commit 6f64417 into main Dec 11, 2023
@roboquat roboquat deleted the gpl/918-fix-subjectid branch December 11, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants