Skip to content

Fix button gap #19306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix button gap #19306

merged 2 commits into from
Jan 9, 2024

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jan 5, 2024

Description

Fixes gap between button children on the New Workspace button

Before Now
image image

Related Issue(s)

Fixes a Slack-raised issue.

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh
Copy link
Contributor

Looks good on /workspaces page

image

But on login page, it looks weird (check image below, Github button gap-1.5 is removed by me, which looks better than other two buttons).

image

@filiptronicek
Copy link
Member Author

filiptronicek commented Jan 8, 2024

/gh run recreate-vm=true

Comment triggered a workflow run

Started workflow run: 7445079682

  • recreate_vm: true

@roboquat roboquat merged commit f458160 into main Jan 9, 2024
@roboquat roboquat deleted the ft/button-gap-fix branch January 9, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants