-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Redirect on workspace stop #19314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect on workspace stop #19314
Conversation
It's working as promised, some very nit questions:
|
Did you check if we can redirect from the inner frame? In that case the required change would be very limited as we only need to adjust the loading screen. |
Not possible as it's a different origin
👍 |
541d876
to
b107a6d
Compare
Reedy for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 🎉
Description
Redirect on workspace stop
Related Issue(s)
Fixes https://linear.app/gitpod/issue/EXP-1082
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold