Skip to content

Redirect on workspace stop #19314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Redirect on workspace stop #19314

merged 8 commits into from
Jan 12, 2024

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Jan 10, 2024

Description

Redirect on workspace stop

Related Issue(s)

Fixes https://linear.app/gitpod/issue/EXP-1082

How to test

  1. Start workspace
  2. Stop workspace, it shoudl redirect automatically to the context url or a custom url from configcat

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh
Copy link
Contributor

mustard-mh commented Jan 11, 2024

It's working as promised, some very nit questions:

  • Does 1 second stopping page then redirect acceptable?
  • Should we add another special value so that it goes back to stopped page like before? (just in case dataops want it back)

@svenefftinge
Copy link
Contributor

svenefftinge commented Jan 11, 2024

Did you check if we can redirect from the inner frame? In that case the required change would be very limited as we only need to adjust the loading screen.
Even if that doesn't work we might want to use messaging (i.e. parent.postMessage)

@jeanp413
Copy link
Member Author

Did you check if we can redirect from the inner frame? In that case the required change would be very limited as we only need to adjust the loading screen.

Not possible as it's a different origin

Even if that doesn't work we might want to use messaging (i.e. parent.postMessage)

👍

@jeanp413
Copy link
Member Author

Reedy for review again

Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🎉

@roboquat roboquat merged commit 10648e1 into main Jan 12, 2024
@roboquat roboquat deleted the jp/relaxed-canidae branch January 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants