Skip to content

[ws-proxy] upgrade golang-crypto #20499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2025
Merged

[ws-proxy] upgrade golang-crypto #20499

merged 4 commits into from
Jan 8, 2025

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Jan 6, 2025

Description

[ws-proxy] upgrade golang-crypto

Related Issue(s)

Fixes CLC-1057

How to test

  1. start a workspace using preview environment
  2. try different auth method with ssh. e.g. password/public key and try vscode desktop, Jetbrains IDE etc.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat added size/M and removed size/S labels Jan 6, 2025
Copy link

socket-security bot commented Jan 6, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
golang/github.com/gitpod-io/[email protected] environment, filesystem, network, shell, unsafe 0 4.18 MB
golang/golang.org/x/[email protected] environment, filesystem, network, shell, unsafe 0 4.17 MB

View full report↗︎

@iQQBot
Copy link
Contributor Author

iQQBot commented Jan 6, 2025

Connect with access token

image

Connect with password
image

Connect with wrong access token
image

Connect with public key
image

Connect with vscode
image

Connect with Jetbrains IDE
image

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iQQBot ! 🙏

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested and works! 🙏

@iQQBot
Copy link
Contributor Author

iQQBot commented Jan 7, 2025

I would like merge it after Wed, so we can have more time on dogfood.

@iQQBot
Copy link
Contributor Author

iQQBot commented Jan 8, 2025

/unhold

@roboquat roboquat merged commit 663fcb9 into main Jan 8, 2025
34 checks passed
@roboquat roboquat deleted the pd/CLC-1057 branch January 8, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants