Enteprise onboarding settings #20508
Conversation
There was a problem hiding this comment.
Did a bit of a cleanup on the policies page, including having extracted some components to their own files under policies/.
There was a problem hiding this comment.
Nice, looks like a very clean cut!
| @@ -48,6 +48,11 @@ message RoleRestrictionEntry { | |||
| repeated OrganizationPermission permissions = 2; | |||
| } | |||
|
|
|||
| message OnboardingSettings { | |||
There was a problem hiding this comment.
This will house all other onboarding settings we plan to introduce
|
@filiptronicek Can't load the preview atm; do we need to re-create it? |
|
@geropl I last re-deployed it about an hour ago, interesting that it's gone again. leeway'ing now... |
| if ( | ||
| !isURL(settings.onboardingSettings.internalLink ?? "", { | ||
| require_protocol: true, | ||
| host_blacklist: ["localhost", "127.0.0.1"], |
There was a problem hiding this comment.
Do we need to exclude IPv6 localhost (::1) as well?
There was a problem hiding this comment.
Sounds good, will add. We don't have to be too strict here though, I just wanted to add URLs that you probably really don't want to add and might try to accidentally.
|
@filiptronicek I can see the setting now (and not edit, as member). But it's not used anywhere else, yet - correct? |
Description
Note
This PR is the first one to touch protobufs since the New Year, meaning a lot of changes in copyright headers. Sorry in advance!
This PR adds a couple of things:
onboardingSettingsshape for the DB, protocol and API proto definition, with for now a singular property,internalLink.Related Issue(s)
Fixes CLC-1064
How to test
/hold