Skip to content

Auto-configure default JVM Xmx based on workspace resources #20536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Jan 21, 2025

Description

Related Issue(s)

Fixes CLC-1085

How to test

1️⃣ Check xmx settings of JetBrains editor with different ws classes on preview environment

  • IntelliJ + small workspace class -> 2G
  • IntelliJ + large workspace class -> 16G * 60% -> around 9G

2️⃣ Customized vmoptions should override the default one

  • Use .gitpod.yml [docs]
  • Use env INTELLIJ_VMOPTIONS configured on user settings. Like INTELLIJ_VMOPTIONS=-Xmx3333m
  • ..

Get current xmx settings
image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh
Copy link
Contributor Author

@iQQBot could you have a look if you have time?

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for use .gitpod.yml setting, it follow settings
image

Tested for non .gitpod.yml setting and without customized env
image

Tested with non .gitpod.yml setting and with customized env
image

@mustard-mh
Copy link
Contributor Author

Thank you! @iQQBot

@roboquat roboquat added size/M and removed size/S labels Jan 22, 2025
@roboquat roboquat merged commit f0763af into main Jan 22, 2025
18 checks passed
@roboquat roboquat deleted the hw/CLC-1085 branch January 22, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants