Skip to content

[dashboard] re-order org docker auth config #20555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jan 27, 2025

Description

Re-order the settings for GITPOD_IMAGE_AUTH, so that it's right next to the related workspace image settings.

Related Issue(s)

Fixes https://gitpod.slack.com/archives/C071G5TTS49/p1737732283525949

How to test

Take a look at the preview environment's org settings.

https://ft-reorder0de6b997d6.preview.gitpod-dev.com/settings

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

  • /werft with-preview
    /hold

Tool: gitpod/catfood.gitpod.cloud
@@ -55,7 +55,7 @@ export const SetupLayout: FC<Props> = ({
)}
</div>
</div>
<div className={`mt-24 ${noMaxWidth ? "" : "max-w-md"}`}>
<div className={`mt-24 ${noMaxWidth ? "" : "max-w-md"} pb-4`}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this drive-by fixes the spacing on the bottom of the setup page, where the "Verify SSO configuration" button had no space below it.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@roboquat roboquat merged commit 014f31a into main Jan 28, 2025
45 of 46 checks passed
@roboquat roboquat deleted the ft/reorder-org-docker-settings branch January 28, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants