Organization-recommended repositories

[filiptronicek]

Description

Adds onboardingSettings.recommendedRepositories to the org settings API and the corresponding UI to go with it.

Workspace list (active recommendations)	Repository settings list	Organization onboarding settings

Related Issue(s)

Fixes CLC-1066

How to test

1. Visit https://ft-repo-recd38d33fa9.preview.gitpod-dev.com/workspaces
2. Go import some repositories (doesn't really matter how many, but the UI looks good with 3)
3. Mark the imported repositories as recommended, as shown on the screenshot in the PR description
4. Go back to the workspace list, you should see the recommendations populated
5. Start a workspace on different repository, after starting, the Dashboard should suggest that repository as part of the suggestions

Documentation

This needs docs for sure, see CLC-1103.

https://github.com/gitpod-io/website/pull/5150

What's missing

• A fixed docs link for the feature
• Pinning the Suggested repos to the top of the list

[socket-security]

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected] 🔁 npm/[email protected]	None	0	34.7 MB	ericfennis

View full report↗︎

[geropl]

I logged in using your link, but don't see any repos on the workspace page:

I see the suggested repos, though:

🫧 Could that be because I'm not an owner (somehow)? 🤔

[geropl]

Uh, once I got a workspace in that list it's there!

Expected?

[geropl]

And now suggested is filled with my repos, which feels off.

Plus, when opening "Opem sample repository", I just see the "default" examples we ship...?

Not sure what exactly I'd expect, but feels odd atm. Will 🧠 a bit about it...

[filiptronicek]

Thanks for the comments @geropl, seems like I missed a crucial part here, which is to show the section not depending on how many suggestions you have from your recent workspaces, but rather to show them depending on those plus the amount of org-suggested repositories (fixed that in c8989fd (#20559)).

The aim here is to offer a couple of repositories for a new org member to get started, and those suggestions then start filling up with recent recommendations for repos - so the behavior you describe in #20559 (comment) is expected. I'm curious about why this "feels off" to you?

This is deliberate because the section is meant to stick and be there for every user in an installation, and after getting themselves familiarized with Gitpod, it makes sense to fill this section with content relevant to the user.

[geropl]

@filiptronicek Sorry of I dropped the ball here: Is the preview reflecting the state you mentioned yesterday, and ready to review?

[filiptronicek]

@geropl yes, the preview should reflect the "Open sample repo" change we discussed yesterday.

[geropl]

I just tested, and here are a couple of things I found:

• the "Suggested" section feels to noisy somehow, and it's purpose is not clear (enough) to me. Not sure how to solve for this
• the "Suggested" sections "pops in" and shifts space around, most pronounced if you have 0 "recommended" repos
• optional 💡 : we could mark the "recommended" repos in the start workspace modal with the same "recommended" bubble we use in the repo list view (there won't be enough horizontal space, so likely a bigger change
• the "remove from suggested repos" is too hidden, e.g. even when knowing about it I had trouble finding it

@filiptronicek Would you have time to sync?

[filiptronicek]

We synced with @geropl and determined the best approach here is to ship the initial backend implementation (along with the frontend management) and look into improving the UX in a follow-up.

I reverted the workspace list changes in 8fa10f1 (#20559).

[geropl]

Love it. Thank you for the great discussion! ✨ ✔️