[dashboard] Fix user preferences workspace timeouts alert #20619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool: gitpod/catfood.gitpod.cloud
filiptronicek
changed the base branch from
ft/avatar-selection-improvements
to
main
geropl
reviewed
Feb 24, 2025
| /** | ||
| * Returns the default workspace timeout for an organization based on their billing mode (does not take into account the organization's own settings) | ||
| */ | ||
| export const useDefaultOrgTimeoutQuery = () => { |
There was a problem hiding this comment.
A bit sad that we have to replicate this logic here... 😕 Ideally, we'd have an API that emits this.
I'm ok with using this PR as short-term fix, though, given the overhead of introducing such an API. We can get back to it if we have the capacity. 👍
There was a problem hiding this comment.
We could totally put this in a OrganizationService.GetDefaultWorkspaceTimeout method. This feels ok for now, as the logic is so simple and since we're going to remove the billing stuff in a couple months, we'll be able to hardcode it instead.
geropl
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Code looks fine (with this caveat), ok to merge ✔️
Can't test due to preview being down, but feels low risk. 👍
roboquat
deleted the
ft/warning-about-default-org-timeout-restriction-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the alert banner in user prefs and also adds the organization default workspace timeout to the org settings.
Related Issue(s)
Fixes CLC-1167
How to test
Allow members to change workspace timeouts(you'll also need to upgrade the org first to a paid plan, which you can do with a424242424242credit card/hold