Skip to content

Updating Go dependency: Docker and Git to fix CVE #20689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

corneliusludmann
Copy link
Contributor

Description

Updating Go dependency: Docker and Git to fix CVE

/hold

Copy link

socket-security bot commented Mar 21, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
golang/github.com/go-git/go-git/[email protected]v5.14.0 None 0 2.41 MB
golang/github.com/google/[email protected] eval, filesystem, network, unsafe 0 470 kB
golang/golang.org/x/[email protected]v0.0.0-20240719175910-8a7402abbf56 None 0 1.52 MB

View full report↗︎

@corneliusludmann corneliusludmann marked this pull request as ready for review March 21, 2025 09:58
@corneliusludmann corneliusludmann requested review from a team as code owners March 21, 2025 09:58
Base automatically changed from cw/bump-go-crypto to main March 21, 2025 10:49
@roboquat roboquat added size/XL and removed size/M labels Mar 21, 2025
Tool: gitpod/catfood.gitpod.cloud
@roboquat roboquat added size/M and removed size/XL labels Mar 21, 2025
@corneliusludmann
Copy link
Contributor Author

It seems that we need to pin opentelemetry dependency because the Dokcer version upgrade is causing a chain of dependency issues. It's now pulling in a newer version of the OpenTelemetry dependencies, but there's a package structure change in OpenTelemetry that's causing the issue. Pinning OpenTelemetry dependencies to compatible versions to resolve go mod tidy failures after upgrading github.com/docker/docker. The newer Docker version was pulling in incompatible OpenTelemetry packages with changed API structure.

@geropl
Copy link
Member

geropl commented Mar 21, 2025

I think doing the pins is good, if it reduces the CVEs.

@corneliusludmann Did you do the go mod tidy dance through all components that depend on docker? IMO we should do that nontheless, to avoid build issues down the line.

@corneliusludmann
Copy link
Contributor Author

corneliusludmann commented Mar 21, 2025

Did you do the go mod tidy dance through all components that depend on docker? IMO we should do that nontheless, to avoid build issues down the line.

go mod tidy with all components and installer does not change anything. @geropl Do you think it needs anything else?

@geropl
Copy link
Member

geropl commented Mar 21, 2025

@corneliusludmann Waiting for this regression test to be 🟢 : https://github.com/gitpod-io/gitpod/actions/runs/13991634122/job/39177564025

Update: DONE!

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change look great! ✔️

@geropl
Copy link
Member

geropl commented Mar 21, 2025

/unhold

@roboquat roboquat merged commit 313610d into main Mar 21, 2025
17 checks passed
@roboquat roboquat deleted the clu/bump-go-docker-git branch March 21, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants