Redact args in the logs of audit log service #20853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
May 27, 2025
geropl
approved these changes
May 27, 2025
There was a problem hiding this comment.
Rubber-stamping ✔️
Please take a look at https://github.com/gitpod-io/gitpod/pull/20853/files#r2109518699 and decide if you want to add a line. 🙏
corneliusludmann
force-pushed
the
clu/redact-args-audit-logs
branch
from
08bc639 to
363ff33
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The args param contains workspace IDs and other sensitive data. Since it's quite hard to detect them, best way is to simply not log it at all. It's still part of the audit database but does not appear in the component logs.
Related Issue(s)
Fixes https://linear.app/gitpod/issue/CLC-666/scrubbing-audit-log-writes-workspaceids-in-plain-text
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold