Skip to content

[werft] Set more strict pre-commit rules #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2021
Merged

[werft] Set more strict pre-commit rules #4850

merged 2 commits into from
Jul 17, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 16, 2021

No description provided.

@roboquat roboquat requested a review from JanKoehnlein July 16, 2021 21:29
@aledbf aledbf requested review from csweichel and removed request for JanKoehnlein July 16, 2021 21:29
@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2021

/assign @csweichel

@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2021

/werft run

👍 started the job as gitpod-build-aledbf-fixprecommit-fork.0

@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2021

/werft run

👍 started the job as gitpod-build-aledbf-fixprecommit-fork.1

@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2021

/werft run

👍 started the job as gitpod-build-aledbf-fixprecommit-fork.2

Update nodeRoots
@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2021

/werft run

👍 started the job as gitpod-build-aledbf-fixprecommit-fork.3

@csweichel
Copy link
Contributor

/lgtm
/approve

@roboquat roboquat added the lgtm label Jul 17, 2021
@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 035fa4e into gitpod-io:main Jul 17, 2021
@aledbf aledbf deleted the aledbf/fixprecommit branch July 23, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants