[link.exe /INTEGRITYCHECK] fix -- ":NO" suffix doesn't work, so update the docs #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You opened a PR to your own fork. The link to open a PR upstream is https://github.com/MicrosoftDocs/cpp-docs/compare/main...glenn-slayden:cpp-docs:glenn-slayden-patch-1?expand=1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc mentions
/INTEGRITYCHECK:NO, but this does not appear to be a valid command line option with the currentlink.exereleases. My version oflinkrejects that syntax entirely.I don't know where the official
link.exesource code is kept, but it likely has the exact same bug in the code that I found in the link below. Due to this obvious bug that I point out in the source code, there seems to be no way to explicilty assert/INTEGRITYCHECKin the negative, except by simply removing the option.https://github.com/microsoft/BuildXL/blob/main/Public/Sdk/Experimental/Msvc/Native/Tools/Link/Link.dsc#L303-L307
I would welcome a
linkdeveloper to fix the program itself, so it works as described, but in the meantime, at least the docs can be changed to reflect the current situation.