Skip to content
This repository was archived by the owner on Dec 2, 2017. It is now read-only.

Add 'Help' menu at left menu bar for Chinese language #77

Merged
merged 5 commits into from
Jan 21, 2017

Conversation

luffyke
Copy link
Contributor

@luffyke luffyke commented Jan 20, 2017

  1. Add help menu with help page at left menu bar, because the help section appear at the bottom in many pages and it misses the gocn.io for Chinese users, this makes many Chinese users ask issues in github by Chinese. This changes was made to avoid such situation, and guide Chinese users ask Chinese issue in gocn.io.
  2. Add github issue and gocn.io channel in help page.
  3. Change all installation page with help section to point to the new help page.

All the changes are tested and expected in locally.
ps, i also make this enhancement for English language, i would post a new PR if you think this is ok for you.

@lunny lunny added this to the 1.1 milestone Jan 20, 2017
@lunny
Copy link
Member

lunny commented Jan 20, 2017

LGTM

@appleboy
Copy link
Member

Missing English docs?

@luffyke
Copy link
Contributor Author

luffyke commented Jan 21, 2017

@appleboy Yes, i don't post English version here as this pr is mainly for Chinese language.

@luffyke
Copy link
Contributor Author

luffyke commented Jan 21, 2017

@appleboy if you think this pr is ok, i can make a new pr for English language.

@appleboy
Copy link
Member

@luffyke OK.

@appleboy
Copy link
Member

LGTM

@lunny lunny merged commit e23dc93 into go-gitea:master Jan 21, 2017
@lunny
Copy link
Member

lunny commented Jan 21, 2017

And please back port to v1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants