Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Use dep instead of govendor #117

Merged
merged 3 commits into from
May 15, 2018
Merged

Use dep instead of govendor #117

merged 3 commits into from
May 15, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented May 14, 2018

I'm creating a PR on gitea to use dep, but I encountered

init failed: unable to solve the dependency graph: Solving failure: No versions of code.gitea.io/git met constraints:
	f1ecc138bebcffed32be1a574ed0c2701b33733f: Could not introduce code.gitea.io/git@f1ecc138bebcffed32be1a574ed0c2701b33733f, as it has a dependency on github.com/Unknwon/com with constraint ^1.0.0, which has no overlap with existing constraint master from (root)
	master: Could not introduce code.gitea.io/git@master, as it has a dependency on github.com/Unknwon/com with constraint ^1.0.0, which has no overlap with existing constraint master from (root)
	appleboy-patch-1: Could not introduce code.gitea.io/git@appleboy-patch-1, as it has a dependency on github.com/Unknwon/com with constraint ^1.0.0, which has no overlap with existing constraint master from (root)
	appleboy-patch-2: Could not introduce code.gitea.io/git@appleboy-patch-2, as it has a dependency on github.com/Unknwon/com with constraint ^1.0.0, which has no overlap with existing constraint master from (root)
	git-1.7.0: Could not introduce code.gitea.io/[email protected], as it has a dependency on github.com/Unknwon/com with constraint ^1.0.0, which has no overlap with existing constraint master from (root)

It seems I have to convert this repo at first.

Gopkg.toml Outdated
@@ -0,0 +1,34 @@
# Gopkg.toml example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally tend to drop these comments, beside that lgtm

@@ -0,0 +1,34 @@
# Gopkg.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunny I think @tboerger was referring to Lines 1-25 when he was talking about removing comments

@sapk
Copy link
Member

sapk commented May 14, 2018

@lunny I am not sure that it will fix your depencies error (github.com/Unknwon/com v1.0.0 in git and master in gitea) except if you force it this one to branch = "master" in place of version = "1.0.0" here.

@lunny
Copy link
Member Author

lunny commented May 15, 2018

@sapk should we use 1.0.0 or master of github.com/Unknwon/com ?

@lunny
Copy link
Member Author

lunny commented May 15, 2018

I changed github.com/Unknwon/com from 1.0.0 to master

Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default help message in comment could be removed but it could be done later and it is not blocking for me.

@lunny lunny merged commit 622cdd1 into go-gitea:master May 15, 2018
@lunny lunny deleted the lunny/dep branch May 15, 2018 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants