This repository was archived by the owner on Apr 12, 2019. It is now read-only.
fix git version below 2.7 #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfranz
suggested changes
May 25, 2018
repo_commit.go
Outdated
| @@ -9,6 +9,7 @@ import ( | |||
| "container/list" | |||
| "strconv" | |||
| "strings" | |||
| "github.com/mcuadros/go-version" | |||
|
@JonasFranzDEV Actually it is not in |
lunny
reviewed
May 25, 2018
| @@ -0,0 +1,33 @@ | |||
| package git | |||
lunny
reviewed
May 25, 2018
repo_commit_test.go
Outdated
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "path/filepath" |
|
maybe test different git version via .drone.yml? |
|
@lunny Shouldn't drone already run tests for latest git and git 1.7? |
|
@daviian Yes, there are already two git versions. LGTM |
lunny
approved these changes
May 25, 2018
jonasfranz
approved these changes
May 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets go-gitea/gitea#3458
Should fix
commitsBeforefor older git versions.