This repository was archived by the owner on Apr 12, 2019. It is now read-only.
forked from gogs/git-module
-
Notifications
You must be signed in to change notification settings - Fork 38
Refactor branch list using src-d/go-git and add GetRefs function #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 33.54% 33.33% -0.22%
==========================================
Files 25 28 +3
Lines 1407 1761 +354
==========================================
+ Hits 472 587 +115
- Misses 862 1096 +234
- Partials 73 78 +5
Continue to review full report at Codecov.
|
lunny
suggested changes
Nov 11, 2018
@lafriks the benchmark is for a bare git repository? |
@lunny yes |
It seems we only have a bare repo on testdata |
@lunny is that a problem? |
I prefer pure go library than git command. But for performance measure, I think a bare repo maybe not a good example. |
We store all git repos as bare server-side so that is measurement most important for gitea case |
lunny
approved these changes
Nov 13, 2018
jonasfranz
approved these changes
Nov 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetRefs will be needed to implement Refs API
Add src-d/go-git dependency and refactored GetBranches to use this lib.