This repository was archived by the owner on Apr 12, 2019. It is now read-only.
Fix for bad commitID to show up in error #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 36.07% 36.48% +0.41%
==========================================
Files 28 28
Lines 1838 1839 +1
==========================================
+ Hits 663 671 +8
+ Misses 1085 1079 -6
+ Partials 90 89 -1
Continue to review full report at Codecov.
|
richmahn
commented
Mar 6, 2019
| @@ -153,13 +153,14 @@ func (repo *Repository) getCommit(id SHA1) (*Commit, error) { | |||
| func (repo *Repository) GetCommit(commitID string) (*Commit, error) { | |||
| if len(commitID) != 40 { | |||
| var err error | |||
| commitID, err = NewCommand("rev-parse", commitID).RunInDir(repo.Path) | |||
| actualCommitID, err := NewCommand("rev-parse", commitID).RunInDir(repo.Path) | |||
| if err != nil { | |||
| if strings.Contains(err.Error(), "unknown revision or path") { | |||
| return nil, ErrNotExist{commitID, ""} | |||
There was a problem hiding this comment.
Here is where commitID was always empty because NewCommand() returned nil for it, replacing the commitID passed to the function.
techknowlogick
approved these changes
Mar 8, 2019
zeripath
approved these changes
Mar 8, 2019
|
Thanks for another PR @richmahn 😄 Now that this has been merged would you be able to update the deps in the main repo? Please let me know if you have any questions. |
|
@techknowlogick Yes, will do that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error message for a bad commitID makes no sense because when the Error object is created, commitID is always empty since NewCommand() call replaced the given commitID. This makes sure we retain the old commitID until after this block.