Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Add GetLatestCommitTime #45

Merged
merged 1 commit into from
May 19, 2017
Merged

Conversation

cez81
Copy link

@cez81 cez81 commented Apr 17, 2017

Get time for latest commit in repo across all branches. To be used in go-gitea/gitea#1329

@lunny
Copy link
Member

lunny commented Apr 18, 2017

for-each-ref will ask git >= v1.9

@bkcsoft
Copy link
Member

bkcsoft commented Apr 18, 2017

Heck, even GitLab requires git 2.8.4 so I think we should be fine bumping from git 1.9 😂

@cez81
Copy link
Author

cez81 commented Apr 18, 2017

No, it should be ok for earlier versions. At least from https://git-scm.com/docs/git-for-each-ref/1.4.4

@lunny
Copy link
Member

lunny commented Apr 18, 2017

@bkcsoft I mean we should document it.

@bkcsoft
Copy link
Member

bkcsoft commented Apr 18, 2017

@lunny Version requirements must be documented yes. But we should also have a init()-function that verifies and panic() if requirements are not meet.

@lunny
Copy link
Member

lunny commented Apr 28, 2017

Please rebase and add the version check.

@cez81
Copy link
Author

cez81 commented Apr 28, 2017

Please rebase and add the version check.

Rebased but I don't think adding version check is needed. Like I said earlier for-each-ref has existed from as early as at least 2006 (git/git@9f613dd#diff-6d644249e994f8d938b2d2313b7a12e1). Git version required for this function will be < version required for the module.

@cez81 cez81 force-pushed the get_latest_commit_time branch 2 times, most recently from dd0a3e4 to 88e76bc Compare April 28, 2017 09:05
@cez81 cez81 force-pushed the get_latest_commit_time branch from 88e76bc to 1d420a5 Compare May 18, 2017 21:23
@sapk
Copy link
Member

sapk commented May 19, 2017

LGTM

1 similar comment
@lunny
Copy link
Member

lunny commented May 19, 2017

LGTM

@lunny
Copy link
Member

lunny commented May 19, 2017

let L-G-T-M work

@lunny
Copy link
Member

lunny commented May 19, 2017

@sapk maybe you should add yourself to the MAINTAINER file

@lunny lunny merged commit af05861 into go-gitea:master May 19, 2017
@cez81 cez81 deleted the get_latest_commit_time branch May 19, 2017 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants