-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
|
Heck, even GitLab requires git 2.8.4 so I think we should be fine bumping from git 1.9 😂 |
No, it should be ok for earlier versions. At least from https://git-scm.com/docs/git-for-each-ref/1.4.4 |
@bkcsoft I mean we should document it. |
@lunny Version requirements must be documented yes. But we should also have a |
Please rebase and add the version check. |
Rebased but I don't think adding version check is needed. Like I said earlier for-each-ref has existed from as early as at least 2006 (git/git@9f613dd#diff-6d644249e994f8d938b2d2313b7a12e1). Git version required for this function will be < version required for the module. |
dd0a3e4
to
88e76bc
Compare
88e76bc
to
1d420a5
Compare
LGTM |
1 similar comment
LGTM |
let L-G-T-M work |
@sapk maybe you should add yourself to the MAINTAINER file |
Get time for latest commit in repo across all branches. To be used in go-gitea/gitea#1329