Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Reduce memory usage on Blob.Data() by ~50% #93

Closed
wants to merge 0 commits into from
Closed

Reduce memory usage on Blob.Data() by ~50% #93

wants to merge 0 commits into from

Conversation

mrexodia
Copy link

@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

@mrexodia tests seems to be failing

@mrexodia
Copy link
Author

mrexodia commented Nov 27, 2017 •
edited
Loading

The test failed because Blob.Data() now uses Blob.Size() to determine how much memory to preallocate. The mock structure testBlob didn't contain a ptree.repo so it crashed...

It has since been fixed.

This was referenced Nov 27, 2017
Merged
Merged
@mrexodia mrexodia closed this Nov 28, 2017
@mrexodia mrexodia mentioned this pull request Nov 28, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrexodia @lafriks @tboerger