simplified code via func

Author: lunny

models/issue_comment.go

@@ -639,6 +639,16 @@ func CreatePullPushComment(doer *User, repo *Repository, issue *Issue, commit *P
 	return err
 }
 
+func updateCommentRepoFullName(e Engine, repoID int64, newRepoFullName string) error {
+	_, err := e.Where("issue_id IN (SELECT id FROM issue WHERE repo_id = ?)", repoID).
+		And("`type` = ?", CommentTypePullPushCommit).
+		Cols("repo_full_name").
+		Update(&Comment{
+			RepoFullName: newRepoFullName,
+		})
+	return err
+}
+
 // GetCommentByID returns the comment by given ID.
 func GetCommentByID(id int64) (*Comment, error) {
 	c := new(Comment)

models/repo.go

@@ -1478,13 +1478,8 @@ func TransferOwnership(doer *User, newOwnerName string, repo *Repository) error
 	}
 
 	// Update comment repofullname
-	if _, err := sess.Where("issue_id IN (SELECT id FROM issue WHERE repo_id = ?)", repo.ID).
-		And("`type` = ?", CommentTypePullPushCommit).
-		Cols("repo_full_name").
-		Update(&Comment{
-			RepoFullName: repo.FullName(),
-		}); err != nil {
-		return fmt.Errorf("update comment: %v", err)
+	if err := updateCommentRepoFullName(sess, repo.ID, repo.FullName()); err != nil {
+		return fmt.Errorf("updateCommentRepoFullName: %v", err)
 	}
 
 	// Remove redundant collaborators.
@@ -1605,14 +1600,7 @@ func ChangeRepositoryName(repo *Repository, oldRepoName, newRepoName string) (er
 		RemoveAllWithNotice("Delete repository wiki local copy", repo.LocalUncycloPath())
 	}
 
-	_, err = x.Where("issue_id IN (SELECT id FROM issue WHERE repo_id = ?)", repo.ID).
-		And("`type` = ?", CommentTypePullPushCommit).
-		Cols("repo_full_name").
-		Update(&Comment{
-			RepoFullName: u.Name + "/" + newRepoName,
-		})
-
-	return err
+	return updateCommentRepoFullName(x, repo.ID, u.Name+"/"+newRepoName)
 }
 
 func getRepositoriesByForkID(e Engine, forkID int64) ([]*Repository, error) {

models/user.go

@@ -806,13 +806,7 @@ func ChangeUserName(u *User, newUserName string) (err error) {
 		Iterate(new(Repository), func(idx int, bean interface{}) error {
 			repo := bean.(*Repository)
 			RemoveAllWithNotice("Delete repository wiki local copy", repo.LocalUncycloPath())
-			_, err := x.Where("issue_id IN (SELECT id FROM issue WHERE repo_id = ?)", repo.ID).
-				And("`type` = ?", CommentTypePullPushCommit).
-				Cols("repo_full_name").
-				Update(&Comment{
-					RepoFullName: newUserName + "/" + repo.Name,
-				})
-			return err
+			return updateCommentRepoFullName(x, repo.ID, newUserName+"/"+repo.Name)
 		}); err != nil {
 		return fmt.Errorf("Delete repository wiki local copy: %v", err)
 	}