Skip to content

Sign: Handle ErrTwoFactorNotEnrolled correctly #10008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2020
Merged

Sign: Handle ErrTwoFactorNotEnrolled correctly #10008

merged 1 commit into from
Jan 26, 2020

Conversation

zeripath
Copy link
Contributor

Correctly handle ErrTwoFactorNotEnrolled in sign checks

@zeripath zeripath added this to the 1.12.0 milestone Jan 26, 2020
@zeripath
Copy link
Contributor Author

Just checked 1.11 handles this correctly - so I have dropped the backport.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2020
@codecov-io
Copy link

Codecov Report

Merging #10008 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10008      +/-   ##
==========================================
+ Coverage   42.25%   42.27%   +0.01%     
==========================================
  Files         610      610              
  Lines       80372    80372              
==========================================
+ Hits        33965    33976      +11     
+ Misses      42227    42218       -9     
+ Partials     4180     4178       -2
Impacted Files Coverage Δ
models/repo_sign.go 36.2% <0%> (ø) ⬆️
models/pull_sign.go 34.86% <0%> (ø) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️
services/pull/patch.go 69.81% <0%> (+5.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d637a...2b33af5. Read the comment docs.

6543
6543 approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2020
@zeripath zeripath merged commit d087f4f into go-gitea:master Jan 26, 2020
@zeripath zeripath deleted the handle-not-enrolled-twofa-error-in-sign branch January 26, 2020 23:44
@zeripath
Copy link
Contributor Author

As this was a bug introduced in master and fixed in master before release I'm making skip-changelog

@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-io @adelowo @6543 @GiteaBot