-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
On merge of already closed PR redirect back to the pulls page #10010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On merge of already closed PR redirect back to the pulls page #10010
Conversation
It seemed simplest to just redirect back with the message "The pull request has been closed." We could be cleverer with double checking that it is a pull etc. but I dunno if it is worth it. I've added a few more checks. |
Codecov Report
@@ Coverage Diff @@
## master #10010 +/- ##
==========================================
- Coverage 42.25% 42.25% -0.01%
==========================================
Files 610 610
Lines 80373 80384 +11
==========================================
+ Hits 33963 33964 +1
- Misses 42230 42241 +11
+ Partials 4180 4179 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks ... but you switched something :D
it appears I am too full of cold to code Co-Authored-By: 6543 <[email protected]>
It appears that I am too full of cold to code! |
No description provided.