Skip to content

trim whitespace of MilestoneName at creation/rename #10017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

trim whitespace of MilestoneName at creation/rename #10017

merged 1 commit into from
Jan 27, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 27, 2020

close #10013

@codecov-io
Copy link

Codecov Report

Merging #10017 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10017      +/-   ##
==========================================
+ Coverage   42.25%   42.26%   +0.01%     
==========================================
  Files         610      610              
  Lines       80384    80387       +3     
==========================================
+ Hits        33963    33974      +11     
+ Misses      42240    42234       -6     
+ Partials     4181     4179       -2
Impacted Files Coverage Δ
models/issue_milestone.go 67.9% <100%> (+0.23%) ⬆️
services/pull/check.go 54.54% <0%> (-2.1%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/patch.go 67.92% <0%> (+1.88%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f6a7a...805fe12. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2020
guillep2k
guillep2k approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if parameter sanitization should be done at the router level. Otherwise LGTM.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2020
@6543
Copy link
Member Author

6543 commented Jan 27, 2020

@guillep2k if done by go not js, api behave the same

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 27, 2020
@zeripath zeripath merged commit 88c3ccb into go-gitea:master Jan 27, 2020
@6543 6543 deleted the trim-whitespace-milestonename branch January 27, 2020 17:34
@lunny
Copy link
Member

lunny commented Jan 28, 2020

Please send backport to v1.11

6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 28, 2020
@6543
trim whitespace of MilestoneName at creation/rename (go-gitea#10017)
a6c62a5
@6543 6543 mentioned this pull request Jan 28, 2020
Merged
@6543
Copy link
Member Author

6543 commented Jan 28, 2020

created backport #10034

lunny pushed a commit that referenced this pull request Jan 28, 2020
@6543 @lunny
trim whitespace of MilestoneName at creation/rename (#10017) (#10034)
315026c
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[Enhancement] trim whitespace of MilestoneName at creation/rename
6 participants
@6543 @codecov-io @lunny @zeripath @guillep2k @GiteaBot