Skip to content

fix gitgraph commit hashes in dark theme #10046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Conversation

silverwind
Copy link
Member

because the CSS was lazy-loaded the rules in arc-green did not win. included the css file in the main bundle to fix. the black dots can not be fixed via CSS because they are drawn in a <canvas>
element unfortunately.

Before:

After:

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 28, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jan 28, 2020
@lafriks lafriks added this to the 1.12.0 milestone Jan 28, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2020
@lafriks
Copy link
Member

lafriks commented Jan 28, 2020

Please resolve conflicts

because the CSS was lazy-loaded the rules in arc-green did not win.
included the css file in the main bundle to fix. the black dots can not
be fixed via CSS because they are drawn in a `<canvas>` element
unfortunately.
@silverwind
Copy link
Member Author

Done. Also removed highlight.css entry that I forgot to remove in b9690d7.

@codecov-io
Copy link

Codecov Report

Merging #10046 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10046   +/-   ##
=======================================
  Coverage   42.25%   42.25%           
=======================================
  Files         611      611           
  Lines       80407    80407           
=======================================
  Hits        33979    33979           
  Misses      42250    42250           
  Partials     4178     4178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9690d7...01c8453. Read the comment docs.

@zeripath zeripath merged commit 7c84dbc into go-gitea:master Jan 28, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants