Remove unused session config on UI #10078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
mrsdizzie
approved these changes
Jan 30, 2020
GiteaBot
added
the
lgtm/need 1
|
Agree, was looking at this and Gitea has never used COOKIE_LIFE_TIME before so macaron always defaulted that value to 0 (which Gitea would show just in the admin config but in reality cookie always last for session only) |
6543
approved these changes
Jan 30, 2020
GiteaBot
added
lgtm/done
|
|
lafriks
added
type/bug
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10073
Caused by #10050 so no backport needed.
This isn't used anywhere in the code-base as far as I can tell. It's not even a config option, and Macaron default is 0.
I left the translation in our locales in case it's ever used in the future, but simply removing it from this template fixes the error.