Skip to content

Fix broken FlushAll #10101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2020
Merged

Fix broken FlushAll #10101

merged 3 commits into from
Feb 1, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 1, 2020

Go contexting is not quite how you expect...

a := ["1", "2", "3"]
for _, i := range a {
   go func() {
      fmt.Println(i)
    } ()
}

will most likely print 3 3 3.

Our linter should have caught this as go vet would catch it

@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 1, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 1, 2020
@codecov-io
Copy link

codecov-io commented Feb 1, 2020

Codecov Report

Merging #10101 into master will decrease coverage by <.01%.
The diff coverage is 74.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10101      +/-   ##
==========================================
- Coverage   43.49%   43.49%   -0.01%     
==========================================
  Files         567      567              
  Lines       79104    79104              
==========================================
- Hits        34409    34403       -6     
- Misses      40447    40454       +7     
+ Partials     4248     4247       -1
Impacted Files Coverage Δ
routers/repo/view.go 39.13% <100%> (-0.87%) ⬇️
modules/setting/cache.go 53.84% <58.82%> (ø) ⬆️
modules/git/commit_info.go 67.8% <63.63%> (ø) ⬆️
modules/cache/cache.go 31.5% <75%> (ø) ⬆️
modules/cache/last_commit.go 80% <80%> (ø) ⬆️
modules/references/references.go 80.32% <80.85%> (ø) ⬆️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/patch.go 66.03% <0%> (-1.89%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66704f0...335eef6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2020
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be more correct imho

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 1, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2020
@zeripath
Copy link
Contributor Author

zeripath commented Feb 1, 2020

Make lg-tm work

@zeripath zeripath merged commit 9b9dd19 into go-gitea:master Feb 1, 2020
@zeripath zeripath deleted the fix-broken-flush branch February 4, 2020 21:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants