-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix broken FlushAll #10101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken FlushAll #10101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10101 +/- ##
==========================================
- Coverage 43.49% 43.49% -0.01%
==========================================
Files 567 567
Lines 79104 79104
==========================================
- Hits 34409 34403 -6
- Misses 40447 40454 +7
+ Partials 4248 4247 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be more correct imho
Co-Authored-By: Lauris BH <[email protected]>
Make lg-tm work |
Go contexting is not quite how you expect...
will most likely print 3 3 3.
Our linter should have caught this as go vet would catch it