Skip to content

make: improve make pr #10165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2020
Merged

make: improve make pr #10165

merged 2 commits into from
Feb 6, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Feb 6, 2020

Improve make pr command to use make pr#10107 in place of previous PR=10107 make pr

@sapk sapk added type/testing type/miscellaneous skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 6, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2020
@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #10165 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10165      +/-   ##
==========================================
- Coverage   43.42%   43.42%   -0.01%     
==========================================
  Files         576      576              
  Lines       79640    79640              
==========================================
- Hits        34585    34580       -5     
- Misses      40781    40785       +4     
- Partials     4274     4275       +1
Impacted Files Coverage Δ
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
services/pull/pull.go 32.43% <0%> (-1.51%) ⬇️
modules/queue/workerpool.go 45.55% <0%> (-1.07%) ⬇️
models/gpg_key.go 55.37% <0%> (+0.55%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update affdf18...e90eaab. Read the comment docs.

@silverwind
Copy link
Member

Should add it to the help target.

@sapk
Copy link
Member Author

sapk commented Feb 6, 2020

@silverwind I will create another PR also to have a way to build ui of the pr which currently is not updated after checkout.

@lafriks lafriks merged commit 730f026 into go-gitea:master Feb 6, 2020
@sapk sapk deleted the improve-make-pr branch February 6, 2020 22:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants