add TAGS variable prereq on make targets that use it #10219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
tag-evidence
branch
3 times, most recently
from
820ef7f to
b7c3184
Compare
Write out TAGS to .make_evidence/tags and compare it to the previous invocation. If they differ, insert the evidence file into the prereqs of targets that use TAGS. I made it .PHONY so it always builds. I did not include the prereq on release tasks, asssuming the will always do a clean build. Fixes: go-gitea#10196
silverwind
force-pushed
the
tag-evidence
branch
from
b7c3184 to
76faf20
Compare
Codecov Report
@@ Coverage Diff @@
## master #10219 +/- ##
==========================================
+ Coverage 43.64% 43.64% +<.01%
==========================================
Files 576 576
Lines 79716 79716
==========================================
+ Hits 34791 34794 +3
+ Misses 40627 40625 -2
+ Partials 4298 4297 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Feb 10, 2020
GiteaBot
added
lgtm/done
lafriks
added
topic/build
sapk
approved these changes
Feb 11, 2020
|
wake up LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write out TAGS to .make_evidence/tags and compare it to the previous invocation. If they differ, insert the evidence file into the prereqs of targets that use TAGS. I made it
.PHONYso it always builds.I did not include the prereq on release tasks, assuming they will always do a clean build.
Fixes: #10196