-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Move fixture generation to contrib and add test #10277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46b9137
to
e6cf45f
Compare
Codecov Report
@@ Coverage Diff @@
## master #10277 +/- ##
=========================================
Coverage ? 43.68%
=========================================
Files ? 585
Lines ? 80988
Branches ? 0
=========================================
Hits ? 35380
Misses ? 41227
Partials ? 4381
Continue to review full report at Codecov.
|
lunny
approved these changes
Feb 15, 2020
lafriks
approved these changes
Feb 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #10247 (review), I've moved the fixture generation to contrib:
I've also added a unit test for checking if the derivative fixtures (currently
access.yml
) match the expected generation.It looks more "natural", but it's a lot more of code. I have mixed feelings of whether this is the best way or the one we've just merged. I'll leave the decision to you guys.