Skip to content

Move fixture generation to contrib and add test #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 15, 2020

Conversation

guillep2k
Copy link
Member

@guillep2k guillep2k commented Feb 15, 2020

As suggested in #10247 (review), I've moved the fixture generation to contrib:

go run -tags 'sqlite sqlite_unlock_notify' contrib/fixtures/fixture_generation.go

I've also added a unit test for checking if the derivative fixtures (currently access.yml) match the expected generation.

It looks more "natural", but it's a lot more of code. I have mixed feelings of whether this is the best way or the one we've just merged. I'll leave the decision to you guys.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b2f04f4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10277   +/-   ##
=========================================
  Coverage          ?   43.68%           
=========================================
  Files             ?      585           
  Lines             ?    80988           
  Branches          ?        0           
=========================================
  Hits              ?    35380           
  Misses            ?    41227           
  Partials          ?     4381
Impacted Files Coverage Δ
models/fixture_generation.go 65.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f04f4...e6cf45f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 15, 2020
@lafriks lafriks merged commit 7e92070 into go-gitea:master Feb 15, 2020
@guillep2k guillep2k deleted the fix-access-test-exp branch February 15, 2020 16:34
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants