-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Re-order GPG signing docs and fix code blocks #10349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
sapk
approved these changes
Feb 18, 2020
silverwind
approved these changes
Feb 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #10349 +/- ##
==========================================
+ Coverage 43.69% 43.71% +0.02%
==========================================
Files 585 585
Lines 81019 81019
==========================================
+ Hits 35398 35419 +21
+ Misses 41230 41214 -16
+ Partials 4391 4386 -5
Continue to review full report at Codecov.
|
zeripath
approved these changes
Feb 18, 2020
|
sapk
approved these changes
Feb 19, 2020
wake up LGTM bot |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/docs
This PR mainly updates/creates documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the section about generating a GPG key to before the config options, as it is technically a pre-requisite and also re-enforces that Gitea will use a specific key for signing rather than a user's etc.
Also changed some code blocks that currently don't render correctly.