Skip to content

Re-order GPG signing docs and fix code blocks #10349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2020
Merged

Conversation

jolheiser
Copy link
Member

Moved the section about generating a GPG key to before the config options, as it is technically a pre-requisite and also re-enforces that Gitea will use a specific key for signing rather than a user's etc.

Also changed some code blocks that currently don't render correctly.

Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
@jolheiser jolheiser added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 18, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2020
@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #10349 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10349      +/-   ##
==========================================
+ Coverage   43.69%   43.71%   +0.02%     
==========================================
  Files         585      585              
  Lines       81019    81019              
==========================================
+ Hits        35398    35419      +21     
+ Misses      41230    41214      -16     
+ Partials     4391     4386       -5
Impacted Files Coverage Δ
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
services/pull/pull.go 33.93% <0%> (+1.5%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.76% <0%> (+1.92%) ⬆️
services/pull/patch.go 62.89% <0%> (+2.51%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️
modules/git/command.go 89.56% <0%> (+2.6%) ⬆️
services/pull/check.go 38.41% <0%> (+5.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f743f4d...3bc6bc8. Read the comment docs.

@sapk
Copy link
Member

sapk commented Feb 18, 2020

wake up LGTM bot ci is still running.

@sapk
Copy link
Member

sapk commented Feb 19, 2020

wake up LGTM bot

@sapk sapk merged commit dc822d5 into go-gitea:master Feb 19, 2020
@jolheiser jolheiser deleted the gpg_docs branch February 19, 2020 01:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants