Skip to content

Tweak language stats bar #10487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 26, 2020

  • Ensure bar does not overflow parent (fixing border-radii)
  • Remove unneccessary borders/background
  • Fix shaky page caused by JS animation miscalculation by setting fixed height on the summary box. Box itself is still shaky during animation, but better it then the whole page.

Fixes: #10474

Before:

image

After:

image

- Ensure bar does not overflow parent
- Remove unneccessary borders/background
- Fix shaky animation caused by JS animation miscalculation by setting
  fixed height on the summary box. Box itself is still shaky during
  animation, but better it then the whole page.

Fixes: go-gitea#10474
@codecov-io
Copy link

Codecov Report

Merging #10487 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10487      +/-   ##
==========================================
+ Coverage   43.66%   43.68%   +0.02%     
==========================================
  Files         586      586              
  Lines       81408    81408              
==========================================
+ Hits        35547    35565      +18     
+ Misses      41460    41433      -27     
- Partials     4401     4410       +9
Impacted Files Coverage Δ
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
models/pull.go 42.37% <0%> (+0.55%) ⬆️
modules/queue/workerpool.go 58% <0%> (+1.06%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.76% <0%> (+1.92%) ⬆️
services/pull/check.go 50% <0%> (+11.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1758125...dcbb1f6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Feb 26, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 26, 2020
@lafriks lafriks merged commit ef798d4 into go-gitea:master Feb 26, 2020
@silverwind silverwind deleted the stats-fixed-height branch February 26, 2020 20:51
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI shakes butt when showing off languages used in repository
5 participants