Skip to content

update: macaron cores,gzip,session #10522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2020
Merged

update: macaron cores,gzip,session #10522

merged 3 commits into from
Feb 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 28, 2020

as title

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 28, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Feb 28, 2020
@codecov-io
Copy link

codecov-io commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #10522 into master will increase coverage by 0.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10522      +/-   ##
==========================================
+ Coverage   43.68%   43.69%   +0.01%     
==========================================
  Files         586      586              
  Lines       81501    81521      +20     
==========================================
+ Hits        35603    35624      +21     
- Misses      41483    41485       +2     
+ Partials     4415     4412       -3
Impacted Files Coverage Δ
modules/util/compare.go 57.77% <100%> (+6.49%) ⬆️
routers/repo/issue.go 38% <100%> (ø) ⬆️
models/notification.go 64.71% <57.14%> (+0.31%) ⬆️
models/issue.go 53.46% <64%> (-0.06%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
services/pull/check.go 50% <0%> (-2.44%) ⬇️
services/pull/pull.go 35.19% <0%> (-0.88%) ⬇️
models/repo.go 51.52% <0%> (+0.19%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccbdd35...8f9fd2f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2020
@lafriks lafriks added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Feb 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2020
@sapk sapk merged commit 8d2059a into go-gitea:master Feb 28, 2020
@6543 6543 deleted the update-macaron-things branch February 28, 2020 11:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
8 participants
@6543 @codecov-io @lunny @lafriks @techknowlogick @sapk @GiteaBot @zeripath