[Backport] Fix redirection path if Slack webhook channel is invalid #10559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path to the hook config is already defined by orgRepoCtx
|
@jamesorlakin you targeted the wrong branch for a backport! |
GiteaBot
added
the
lgtm/need 2
|
You need to create new commit for release/v1.11 branch |
git checkout -f origin/release/v1.11 -b backport_xy
git cherry-pick c08c975d368771237d6509df915d3ec315186612
git push -u originand select release/v.1.11 as target on pull create (for example) |
|
Oh wow, whoops! I even did the cherry pick step but forgot to branch from release... I'll be able to sort it tomorrow when I'm back home 🙂 |
|
I'll close this one. 😉 |
|
Haha, probably wise |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backport of #10548 because the label was added