Skip to content

Fix make find command #10580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2020
Merged

Fix make find command #10580

merged 1 commit into from
Mar 2, 2020

Conversation

silverwind
Copy link
Member

Continuation of #10577

This version also includes an additional fix for Darwin and FreeBSD which do not accept the -regextype option, but only -E and the argument order is specifically required like this for -E to work.

@jolheiser please confirm this works for you.

@guillep2k @silverwind
Fix make find command
045077b 
Continuation of go-gitea#10577

This version also includes an additional fix for Darwin and FreeBSD
which do not accept the `-regextype` option, but only `-E` and the
argument order is specifically required like this for `-E` to work.
jolheiser
jolheiser approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 2, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5e1438b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10580   +/-   ##
=========================================
  Coverage          ?   43.71%           
=========================================
  Files             ?      585           
  Lines             ?    82014           
  Branches          ?        0           
=========================================
  Hits              ?    35854           
  Misses            ?    41717           
  Partials          ?     4443

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1438b...045077b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Mar 2, 2020
@guillep2k guillep2k added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 2, 2020
@zeripath zeripath merged commit ac4f952 into go-gitea:master Mar 2, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @codecov-io @guillep2k @jolheiser @zeripath @GiteaBot