Skip to content

Fix LFS max file size enforcement #10593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 3, 2020

Unfortunately the batch handler also needs to enforce max file size.
Enforce max file size in batch handler

Unfortunately the batch handler also needs to enforce max file size.
Enforce max file size in batch handler
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 3, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 3, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 3, 2020
@jolheiser
Copy link
Member

Do we have tests for this already that can be extended, per chance?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2020
@jolheiser
Copy link
Member

Ping lgtm

@codecov-io
Copy link

Codecov Report

Merging #10593 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10593      +/-   ##
==========================================
- Coverage   43.72%   43.71%   -0.02%     
==========================================
  Files         585      585              
  Lines       82031    82031              
==========================================
- Hits        35872    35856      -16     
- Misses      41719    41734      +15     
- Partials     4440     4441       +1
Impacted Files Coverage Δ
models/repo_mirror.go 2.12% <0%> (-10.64%) ⬇️
modules/indexer/stats/db.go 50% <0%> (-9.38%) ⬇️
services/pull/pull.go 34.7% <0%> (-1.18%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
services/mirror/mirror.go 18.75% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51c258...492a314. Read the comment docs.

@jolheiser jolheiser merged commit 0b3a9c4 into go-gitea:master Mar 3, 2020
@zeripath zeripath deleted the fix-LFS-max-file-size branch April 1, 2020 18:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants