Skip to content

Modernize docs/assets/js/search.js #10621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2020
Merged

Modernize docs/assets/js/search.js #10621

merged 2 commits into from
Mar 9, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 5, 2020 •
edited
Loading

  • reformated file with eslint's --fix
  • did some minor rule adjustments
  • removed unneccesary console debug
  • fixed a typo

@silverwind
Copy link
Member Author

silverwind commented Mar 5, 2020 •
edited
Loading

I know it's not ideal to lint this in the webpack target, but I plan to move it to a dedicated lint target soon.

Edit: Removed it for now from automated linting.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 5, 2020
@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/code-linting skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Mar 5, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 5, 2020
@silverwind
Copy link
Member Author

Note the code is not IE11 compatible, but I guess the JS features on the page are not that essential for its function.

@codecov-io
Copy link

Codecov Report

Merging #10621 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10621      +/-   ##
==========================================
+ Coverage   43.66%   43.68%   +0.02%     
==========================================
  Files         587      587              
  Lines       82183    82183              
==========================================
+ Hits        35886    35903      +17     
+ Misses      41843    41828      -15     
+ Partials     4454     4452       -2
Impacted Files Coverage Δ
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/pull.go 35.88% <0%> (+1.17%) ⬆️
services/pull/check.go 55.48% <0%> (+2.43%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️
services/pull/patch.go 64.51% <0%> (+2.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3502730...7a56ec6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 6, 2020
@silverwind silverwind changed the title add assets/js/search.js to linting and fix issues Modernize docs/assets/js/search.js Mar 6, 2020
@silverwind silverwind force-pushed the searchjs branch 2 times, most recently from e2a20ff to 35f0be5 Compare March 6, 2020 13:00
@silverwind
Copy link
Member Author

Branch was messed up, fixed.

@silverwind
Modernize docs/assets/js/search.js
46c65c9 
- reformated file with eslint's --fix
- did some minor rule adjustments
- removed unneccesary console debug
- fixed a typo
@silverwind
Copy link
Member Author

rebased

@guillep2k
Copy link
Member

PING LG-TM

@guillep2k guillep2k merged commit d665764 into go-gitea:master Mar 9, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @codecov-io @guillep2k @lunny @lafriks @GiteaBot